Skip to content

docs: Add try-catch to getting started#745

Merged
kwridan merged 1 commit intotuist:mainfrom
AlexKobachiJP:fix-getting-started
Mar 6, 2023
Merged

docs: Add try-catch to getting started#745
kwridan merged 1 commit intotuist:mainfrom
AlexKobachiJP:fix-getting-started

Conversation

@AlexKobachiJP
Copy link
Copy Markdown
Contributor

Not sure if this was left out on purpose to keep the sample as small as possible but I feel that a getting started document should show code that builds without requiring fixes, even if it is as simple as adding a try statement, because it otherwise makes the documentation look sloppy.

(Apologies for not creating an issue first.)

Copy link
Copy Markdown
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this @AlexKobachiJP

Agreed, making the docs closer to reality is needed. At the very least try ... incase someone does copy and paste the snippet. 👍

@kwridan
Copy link
Copy Markdown
Collaborator

kwridan commented Feb 21, 2023

@all-contributors add @AlexKobachiJP for docs

@allcontributors
Copy link
Copy Markdown
Contributor

@kwridan

I've put up a pull request to add @AlexKobachiJP! 🎉

@AlexKobachiJP
Copy link
Copy Markdown
Contributor Author

Thanks!

@kwridan kwridan merged commit bdf32a6 into tuist:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants