Skip to content

Fix $skipPermissionsUpdate #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 10 commits into from
Jul 28, 2025
Merged

Fix $skipPermissionsUpdate #640

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7d61325
check isset
fogelito Jul 28, 2025
cdec2ab
Use array_key_exists
fogelito Jul 28, 2025
2613dde
Use isset
fogelito Jul 28, 2025
2d37031
Use array_key_exists
fogelito Jul 28, 2025
4b9fb29
$skipPermissionsUpdate true
fogelito Jul 28, 2025
15e985b
Remove comment
fogelito Jul 28, 2025
e46c4ff
$skipPermissionsUpdate true
fogelito Jul 28, 2025
957a496
Remove comment
fogelito Jul 28, 2025
5f6c1fb
Add test
fogelito Jul 28, 2025
f76954b
formatting
fogelito Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Database/Database.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4108,7 +4108,7 @@ public function updateDocument(string $collection, string $id, Document $documen
fn () => $this->getDocument($collection->getId(), $id, forUpdate: true)
));

$skipPermissionsUpdate = false;
$skipPermissionsUpdate = true;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

if ($document->offsetExists('$permissions')) {
$originalPermissions = $old->getPermissions();
Expand Down Expand Up @@ -4941,7 +4941,7 @@ public function createOrUpdateDocumentsWithIncrease(
)));
}

$skipPermissionsUpdate = false;
$skipPermissionsUpdate = true;

if ($document->offsetExists('$permissions')) {
$originalPermissions = $old->getPermissions();
Expand Down