Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b7eb70461
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tsconfig.json
Outdated
| // TypeScript does not currently expose a separate "node20" resolution mode. | ||
| // The Node-style resolver remains under the node16/nodenext family, and this | ||
| // is the stable choice for Node-oriented workflows in this repo. | ||
| "moduleResolution": "node16" |
There was a problem hiding this comment.
Use bundler resolution for root TypeScript config
Setting moduleResolution to node16 in the repo-level tsconfig.json makes TypeScript enforce explicit file extensions for ESM relative imports, but this config still includes modules/*/src and modules/*/test, which contain many extensionless imports (for example import './common'). As a result, any tooling that type-checks against the root config (e.g. tsc -p tsconfig.json or editor diagnostics) now reports a large number of TS2835 errors, which is a regression from the previous config behavior.
Useful? React with 👍 / 👎.
Summary
Removes deprecated TypeScript options that will stop working in TypeScript 7 and updates the repo config to support modern package resolution behavior, including future
package.jsonexportsusage.Changes
baseUrlusage from the shared TypeScript configmoduleResolution: "node"usagetsconfig.base.jsonfor shared compiler settingstsconfig.build.jsonfor package build-specific settingstsconfig.jsonfiles to extend the build configmodule: "Node20"withmoduleResolution: "node16"pathsentries to explicit relative targets so they work withoutbaseUrlWhy
TypeScript 6 reports the previous config as deprecated:
baseUrlmoduleResolution: "node"(legacynode10behavior)This change prepares the repo for TypeScript 7 by moving to non-deprecated settings while preserving existing build behavior and avoiding bundler-only resolution in Node-oriented test/tooling flows.
Validation
yarn build