Add a page on scanning, call out some packages in pipewire.md and amd.md#891
Open
KeepBotting wants to merge 3 commits intovoid-linux:masterfrom
Open
Add a page on scanning, call out some packages in pipewire.md and amd.md#891KeepBotting wants to merge 3 commits intovoid-linux:masterfrom
KeepBotting wants to merge 3 commits intovoid-linux:masterfrom
Conversation
Member
|
please separate this into multiple commits, one for each topic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple of stumbling blocks I've either experienced myself or come across while hanging out in #voidlinux
The changes are mostly calling out packages which aren't as discoverable as I figure they should be. No package depends upon them, so users might not know they are required for specific functionality.
I have also considered postinstall messages, e.g. the line about
ROCm-SMIis really aboutbtopso maybe it doesn't belong on the docs page for AMD graphics drivers, and should be a postinst message forbtopinstead.Or perhaps both: since
ROCm-SMIis undoubtedly related to AMD graphics drivers, the docs could mention it. Andbtophappens to have missing functionality ifROCm-SMIis not installed, so a postinst message could address this.Let me know what you think.