implement show only preview feature using toggle button#291
Open
mg5566 wants to merge 6 commits intovuejs:mainfrom
Open
implement show only preview feature using toggle button#291mg5566 wants to merge 6 commits intovuejs:mainfrom
mg5566 wants to merge 6 commits intovuejs:mainfrom
Conversation
Update types.ts to include a new injection key for showing the preview reference.
- add showPreview ref to provider - apply showPreview ref to editroSlot
|
@mg5566 is attempting to deploy a commit to the vuejs Team on Vercel. A member of the Team first needs to authorize it. |
Author
FeedbackI'm not sure what to do with the provider / inject key name. |
sxzz
reviewed
Oct 22, 2024
Member
sxzz
left a comment
sxzz
left a comment
There was a problem hiding this comment.
How should we change showPreview for controlling? Maybe should put showPreview to props.
yyx990803
force-pushed
the
main
branch
2 times, most recently
from
06a2e36 to
41d770d
Compare
|
I really like the Dart naming conventions for guidance here: https://dart.dev/effective-dart/design The "show" prefix can be troublesome, it has many verb and noun meanings. I know ts types are context, but at a glance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implement a show only preview toggle button
On small screens, the toggle button below disappears.
On larger screens, it should look like the video below.
2024-10-20.3.56.14.mov
close #290