Conversation
chfast
force-pushed
the
fix_funcsec_validation
branch
from
250567a to
816b628
Compare
chfast
commented
May 24, 2020
axic
approved these changes
May 25, 2020
Member
axic
left a comment
axic
left a comment
There was a problem hiding this comment.
Looks good to me, but how come this isn't fixing a spectest error?
gumb0
approved these changes
May 25, 2020
chfast
force-pushed
the
fix_funcsec_validation
branch
from
816b628 to
94b6f37
Compare
The validation of type indices in function section must be fully finished before processing any code. This is because there may be a call in code[i] referencing function[i + n].
chfast
force-pushed
the
fix_funcsec_validation
branch
from
e3bacc4 to
e03eaeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation of type indices in function section must be fully
finished before processing any code. This is because there may be a call
in code[i] referencing function[i + n].