Conversation
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 99.15% 99.16%
=======================================
Files 43 43
Lines 12972 12980 +8
=======================================
+ Hits 12863 12871 +8
Misses 109 109 |
gumb0
reviewed
Jun 25, 2020
Member
|
@chfast did you benchmark the effect of this? |
Collaborator
Author
|
chfast
force-pushed
the
stack_drop
branch
2 times, most recently
from
8bddacd to
5fb35fc
Compare
gumb0
reviewed
Jun 26, 2020
gumb0
reviewed
Jun 26, 2020
Collaborator
|
Looks good, two minor nitpicks. |
gumb0
approved these changes
Jun 26, 2020
Instead of keeping information about the absolute height to rewind the stack to, keep the number of stack items to drop (without the number of results - arity of the result type).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of keeping information about the absolute height to rewind the
stack to, keep the number of stack items to drop (without the number of
results - arity of the result type).
This makes OperandStack simpler (no need to track the bottom of the stack). No speed change.