Move execute(Module, ...) to execute_helpers.hpp (testutils)#409
Merged
Move execute(Module, ...) to execute_helpers.hpp (testutils)#409
Conversation
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 46 47 +1
Lines 13187 13189 +2
=======================================
+ Hits 13078 13080 +2
Misses 109 109 |
gumb0
approved these changes
Jul 7, 2020
axic
approved these changes
Jul 8, 2020
Member
axic
left a comment
axic
left a comment
There was a problem hiding this comment.
This is 99% the same what I had, except I named the file differently and left a comment to still remove it. Can't recall why I didn't liked it, so okay to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This an overload of execute that takes a module and instantiate it internally. This is convenient for unit tests but rather not desirable in "public" headers. So it is moved to testutils.