Conversation
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 47 49 +2
Lines 13189 13232 +43
=======================================
+ Hits 13080 13123 +43
Misses 109 109 |
chfast
approved these changes
Jul 9, 2020
Collaborator
chfast
left a comment
chfast
left a comment
There was a problem hiding this comment.
In the end I think it is fine to have it.
lib/fizzy/constexpr_vector.hpp
Outdated
| /// It allows to have a collection (constexpr array) of such lists, where list lengths vary across | ||
| /// the collection, but each length is still known at compile time (and doesn't exceed MaxSize | ||
| /// limit). | ||
| template <typename T, std::size_t MaxSize> |
Collaborator
There was a problem hiding this comment.
Suggested change
| template <typename T, std::size_t MaxSize> | |
| template <typename T, std::size_t MaxCapacity> |
Or just Capacity.
| /// the collection, but each length is still known at compile time (and doesn't exceed MaxSize | ||
| /// limit). | ||
| template <typename T, std::size_t MaxSize> | ||
| class constexpr_vector |
Collaborator
There was a problem hiding this comment.
Can be also named static_vector as in https://github.com/gnzlbg/static_vector#3-existing-practice.
Also found a precedence of constexpr_vector: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0597r0.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for #403