Merged
Conversation
axic
commented
Feb 1, 2021
| if self.0.is_null() { | ||
| return Err(()); | ||
| } | ||
| assert!(!self.0.is_null()); |
Member
Author
There was a problem hiding this comment.
Having null here is an error of using the Rust API and not a proper error emitted by the C code.
axic
commented
Feb 1, 2021
| } | ||
| } | ||
|
|
||
| impl From<ExecutionResult> for sys::FizzyExecutionResult { |
Member
Author
There was a problem hiding this comment.
This has not been used and probably will not be used in this form, rather as a Box<>. Will add it back when needed.
The pointer can only be null if there is an invalid usage of the Rust API.
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
+ Coverage 99.27% 99.32% +0.04%
==========================================
Files 73 73
Lines 10883 10885 +2
==========================================
+ Hits 10804 10811 +7
+ Misses 79 74 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
approved these changes
Feb 1, 2021
chfast
approved these changes
Feb 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.