Conversation
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 73 73
Lines 10917 10917
=======================================
Hits 10844 10844
Misses 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. |
chfast
changed the title
gumb0
approved these changes
Feb 3, 2021
axic
reviewed
Feb 3, 2021
| steps: | ||
| - restore_cache: | ||
| name: "Restore cargo cache" | ||
| key: cargo- |
Member
There was a problem hiding this comment.
Does this mean it will pick up anything? Latest?
Collaborator
Author
There was a problem hiding this comment.
It suppose to download the latest matching this prefix. We cannot match with Cargo.lock because it does not exist here.
axic
reviewed
Feb 3, 2021
| cargo install cargo-binutils rustfilt | ||
| - run: | ||
| name: Build (debug mode) | ||
| command: RUSTFLAGS="-Z instrument-coverage" cargo +nightly build --target x86_64-unknown-linux-gnu |
Member
There was a problem hiding this comment.
I think --target x86_64-unknown-linux-gnu can be removed, but it does not hurt. It was needed in chisel because it was also built to the wasm target.
axic
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.