Skip to content

testfloat: Rename -ignoreNaNs to -ignore_nan_payloads#718

Merged
chfast merged 1 commit intomasterfrom
testfloat_nan_payloads
Feb 4, 2021
Merged

testfloat: Rename -ignoreNaNs to -ignore_nan_payloads#718
chfast merged 1 commit intomasterfrom
testfloat_nan_payloads

Conversation

@chfast
Copy link
Copy Markdown
Collaborator

@chfast chfast commented Feb 3, 2021

Change the testfloat option name to be more specific what it does:
ignores specific NaN payload values, but NaN categories are still
checked.

@chfast chfast requested review from axic and gumb0 February 3, 2021 17:36
@chfast chfast force-pushed the testfloat_nan_payloads branch from 891c66b to d805411 Compare February 4, 2021 09:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2021

Codecov Report

Merging #718 (59ce7ac) into master (2b0693c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          73       73           
  Lines       11110    11110           
=======================================
  Hits        11022    11022           
  Misses         88       88           
Flag Coverage Δ
rust 96.44% <ø> (ø)
spectests 90.84% <ø> (ø)
unittests 99.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/testfloat/testfloat.cpp 89.51% <100.00%> (ø)

Change the testfloat option name to be more specific what it does:
ignores specific NaN payload values, but NaN categories are still
checked.
@chfast chfast force-pushed the testfloat_nan_payloads branch from d805411 to 59ce7ac Compare February 4, 2021 09:41
@chfast chfast merged commit 1e48e34 into master Feb 4, 2021
@chfast chfast deleted the testfloat_nan_payloads branch February 4, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants