Conversation
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
==========================================
- Coverage 99.25% 99.25% -0.01%
==========================================
Files 76 76
Lines 11574 11567 -7
==========================================
- Hits 11488 11481 -7
Misses 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
approved these changes
Mar 12, 2021
axic
reviewed
Mar 12, 2021
axic
reviewed
Mar 12, 2021
axic
reviewed
Mar 12, 2021
axic
approved these changes
Mar 12, 2021
axic
reviewed
Mar 18, 2021
| Instance& instance, FuncIdx func_idx, const Value* args, int depth = 0) noexcept; | ||
| Instance& instance, FuncIdx func_idx, const Value* args, int depth) noexcept; | ||
|
|
||
| /// Execute a function from an instance starting at default depth of 0. |
Member
There was a problem hiding this comment.
I'd add "Arguments and behaviour is the same as execute."
axic
reviewed
Mar 18, 2021
| /// Execute a function from an instance starting at default depth of 0. | ||
| inline ExecutionResult execute(Instance& instance, FuncIdx func_idx, const Value* args) noexcept | ||
| { | ||
| const int depth = 0; |
Member
There was a problem hiding this comment.
Not sure it makes a difference, but constexpr?
axic
approved these changes
Mar 18, 2021
Member
axic
left a comment
axic
left a comment
There was a problem hiding this comment.
Looks good to me, but the doxygen improvement should be applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for landing
ExecutionContext, the default value for depth param is dropped in C++ and the param is completely removed from C and Rust (therefore C and Rust are not able to legally call wasm functions from host functions temporarily).