Skip to content

Improve example development .env files#1107

Merged
outdooracorn merged 3 commits intomainfrom
example-env-hints
Apr 7, 2026
Merged

Improve example development .env files#1107
outdooracorn merged 3 commits intomainfrom
example-env-hints

Conversation

@outdooracorn
Copy link
Copy Markdown
Member

@outdooracorn outdooracorn commented Mar 19, 2026

Improve example development .env files

  • Add comment to explain how each one is intended to be used
  • Use a correct value for VUE_APP_API_URL env var
  • Use more sensible values for VUE_APP_CNAME_RECORD and VUE_APP_SUBDOMAIN_SUFFIX env vars
  • Remove confusing # todo replace with test key comment

Bug: T420581

@outdooracorn outdooracorn self-assigned this Mar 19, 2026
@github-actions
Copy link
Copy Markdown

Deployment previews on netlify for branch refs/pull/1107/merge will be at the following locations (when build is done):

Copy link
Copy Markdown
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these descriptions aren't right. I'm not actually 100% sure though

* Add comment to explain how each one is intended to be used
* Use a correct value for `VUE_APP_API_URL` env var
* Use a more sensible values for `VUE_APP_CNAME_RECORD` and `VUE_APP_SUBDOMAIN_SUFFIX` env vars
@outdooracorn outdooracorn changed the title Add hints for when to use the example development .env files Improve example development .env files Apr 7, 2026
Co-authored-by: Thomas Arrow <tarrow@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than oversight of the domain in prod file

@outdooracorn outdooracorn merged commit eefceed into main Apr 7, 2026
7 checks passed
@outdooracorn outdooracorn deleted the example-env-hints branch April 7, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants