Remove always false PHP version comparison if statements#401
Merged
PhiloNL merged 1 commit intowire-elements:mainfrom Jan 6, 2024
Merged
Remove always false PHP version comparison if statements#401PhiloNL merged 1 commit intowire-elements:mainfrom
PhiloNL merged 1 commit intowire-elements:mainfrom
Conversation
Contributor
|
Thanks! |
camerontucker
added a commit
to regentcollege/modal
that referenced
this pull request
Jan 16, 2024
Remove PHP version comparison if statements (wire-elements#401)
camerontucker
added a commit
to regentcollege/modal
that referenced
this pull request
Jan 16, 2024
Remove PHP version comparison if statements (wire-elements#401)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
ifstatements that check if the value ofPHP_VERSION_IDis less than70400(the PHP version is older than 7.4). These expressions are always false, as the minimum required PHP version of the package is 8.1.