fix missing ")" on query selector#432
Merged
PhiloNL merged 2 commits intowire-elements:mainfrom Apr 12, 2024
ph7jack:fix-focusable-query-selector
Merged
fix missing ")" on query selector#432PhiloNL merged 2 commits intowire-elements:mainfrom ph7jack:fix-focusable-query-selector
PhiloNL merged 2 commits intowire-elements:mainfrom
ph7jack:fix-focusable-query-selector
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the JavaScript query selector used in
modal.focusables(). The update corrects the syntax of the:not pseudo-classapplied to input elements, ensuring hidden inputs are properly excluded from the selection. This change enhances the functionality and reliability of our UI element selection logic.Changes
Thanks for your time!