Dispatch an event to a modal being closed before closing it, so that the modal can prevent it based on its state#466
Merged
PhiloNL merged 4 commits intowire-elements:mainfrom Oct 7, 2024
Conversation
…the modal can prevent it based on its state
Contributor
Author
|
Hey @PhiloNL, What is your opinion of this PR? I created it fo fulfill a client requirement in a project, so I'm really interested that it's merged. If you see that it needs some changes, please let me know - I'm willing to make them. In a word, please let me know how I can be of help with this. |
Contributor
|
@osmianski thanks for the PR! Looks good :) If you could update the docs as well, that would be great 🙌 |
Contributor
Author
|
I updated the docs. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows a modal to prevent closure on Escape or on click away based on its state.
The idea is that before closing the modal, an event is dispatched, and the modal can handle it and, if needed, prevent closing the modal.
For example, if a modal has a
isDirtyproperty, it could have the following handler: