[netlify] allow opting out of Image CDN#120
Conversation
🦋 Changeset detectedLatest commit: 945ee59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/netlify/src/index.ts
Outdated
| * | ||
| * If disabled, Astro's built-in image optimization is run at build-time instead. | ||
| * | ||
| * @default enabled |
There was a problem hiding this comment.
| * @default enabled | |
| * @default {true} |
There was a problem hiding this comment.
We're also using enabled/disabled wording for the comment above. Personally, I prefer the english wording here as opposed to code syntax - but it's a preference thing. Is there a guideline on this in the Astro docs? cc @sarah11918
There was a problem hiding this comment.
This is JSDoc, which wants a value: https://jsdoc.app/tags-default
In this case, enabled isn't a valid value for this property
There was a problem hiding this comment.
Fair point - gonna change this here and in the other comment.
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Thank you for addressing this so quickly!
3 participants
Changes
As per #118, this adds an opt-out option for Image CDN.
Testing
Added new unit tests.
Docs
This is a new config option. We should probably mention it in the Astro integration docs.