This repository was archived by the owner on Feb 10, 2025. It is now read-only.
fix(netlify): shim process.env in edge middleware#255
Merged
alexanderniebuhr merged 4 commits intowithastro:mainfrom May 7, 2024
Merged
fix(netlify): shim process.env in edge middleware#255alexanderniebuhr merged 4 commits intowithastro:mainfrom
alexanderniebuhr merged 4 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 1a45eef The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alexanderniebuhr
approved these changes
May 6, 2024
Co-authored-by: Alexander Niebuhr <alexander@nbhr.io>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Netlify Edge Functions don't define
process.env, but Vite uses it for any code that accessesimport.meta.env. This PR imports the Denonode:processpolyfill at the top of the bundled middleware edge functionFixes #254
Testing
Tested with repro site https://github.com/jamesarosen/astro-broken-middleware-demo
Docs