This repository was archived by the owner on Feb 10, 2025. It is now read-only.
perf(netlify): handle dependency tracing for SSR function#296
Merged
perf(netlify): handle dependency tracing for SSR function#296
Conversation
🦋 Changeset detectedLatest commit: f5fa01e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Invalid command. Expected: "/preview " |
Contributor
Author
|
!preview netlify-nft |
Contributor
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
Contributor
Author
|
!preview netlify-nft |
Contributor
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
ematipico
reviewed
Jun 27, 2024
ematipico
approved these changes
Jun 27, 2024
Contributor
Author
|
WINDOWS PATHS 😱 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Currently this adapter relies on the Netlify build process to bundle and trace the SSR functions. This can be slow, particularly when there are a large number of generated chunks from content collections. This PR changes the adapter to handle its own tracing using
@vercel/nft. This is already done in the@astrojs/vercel, so I've mostly taken the code from there and adapted it a bit. Once we've done that we can tell Netlify to not bundle the generated function. For context, the astro.build site was taking over 6 minutes to bundle before this. With this PR, the bundling takes 6 secondsSee https://app.netlify.com/teams/ascorbic/builds/667d304a908d450008617d30 for an example build
Testing
Docs