This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Conversation
🦋 Changeset detectedLatest commit: 87e6eb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Jul 1, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Astro 4.11 had a regression that caused edge middleware bundling to fail on Netlify in some situations. This seems to have been a side effect of something being imported into middleware that used astro:assets, which meant that sharp became a dependency. Sharp uses lots of node builtins, which aren't compatible with middleware, so builds were failing.
This PR sets sharp to "external", ensuring it's never bundled. In future we should think about ways to avoid these kinds of cross-runtime imports happening.
Testing
A test was failing that is now fixed
Docs