Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twelve-grapes-dream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/cloudflare': patch
---

Fixes a regression which caused the adapter to falsely return an empty 404 response, caused by an upstream change https://github.com/withastro/astro/pull/7754.
9 changes: 1 addition & 8 deletions packages/cloudflare/src/entrypoints/server.advanced.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ export function createExports(manifest: SSRManifest) {
return env.ASSETS.fetch(request);
}

let routeData = app.match(request, { matchNotFound: true });
if (routeData) {
let routeData = app.match(request);
Reflect.set(
request,
Symbol.for('astro.clientAddress'),
Expand All @@ -67,12 +66,6 @@ export function createExports(manifest: SSRManifest) {
}

return response;
}

return new Response(null, {
status: 404,
statusText: 'Not found',
});
};

return { default: { fetch } };
Expand Down
9 changes: 1 addition & 8 deletions packages/cloudflare/src/entrypoints/server.directory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ export function createExports(manifest: SSRManifest) {
return env.ASSETS.fetch(request);
}

let routeData = app.match(request, { matchNotFound: true });
if (routeData) {
let routeData = app.match(request);
Reflect.set(
request,
Symbol.for('astro.clientAddress'),
Expand All @@ -60,12 +59,6 @@ export function createExports(manifest: SSRManifest) {
}

return response;
}

return new Response(null, {
status: 404,
statusText: 'Not found',
});
};

return { onRequest, manifest };
Expand Down