404 page doesn't render in production mode

[xriter]

What version of astro are you using?

2.10.7

Are you using an SSR adapter? If so, which one?

Node

What package manager are you using?

npm

What operating system are you using?

Mac

What browser are you using?

Safari

Describe the Bug

In SSR mode, when going to a page that doesn't exist, the 404 page should be rendered (the default or custom one). It does this correctly in dev mode, but in production mode it only renders a blank page.

Using @astrojs/node 5.3.3 with node v18.16.1

Also see the repro.
Run npm run build && npm run preview and go to /doesntexist.

What's the expected result?

The 404 page should be rendered correctly in SSR production mode.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-trfvka?file=src%2Fpages%2Findex.astro

Participation

• I am willing to submit a pull request for this issue.

[natemoo-re]

Guessing that this will be closed by #8070 which fixes a few edge cases introduced in #7754

[lilnasy]

@xriter Could not reproduce the issue.

Works the same in dev and build on stackblitz.

[xriter]

@lilnasy I made a little 🎞️ screen recording showing how to reproduce in Stackblitz.
Check out the video: https://github.com/withastro/astro/assets/70454441/6c1b6748-99b0-4b80-9c41-39e055ed95d1

(Besides that I also experience this problem in real world projects of course).

[lilnasy]

Is there a difference when you run node dist/server/entry.mjs instead of npm run preview?

[xriter]

@lilnasy I just tried. When running node dist/server/entry.mjs the 404 page DOES render indeed. 🤔
So what's the difference? I guess it also still should be working correctly when running npm run preview? (At least it did so before...)

Although, I run a website in production in a Docker container, (that is using node dist/server/entry.mjs), and there it does not work... Wondering if it has something to do with the domain or dns (localhost vs 127.0.0.1)...

[xriter]

@lilnasy Not fully convinced about the workaround tag. See my updated previous comment. 🙈

[lilnasy]

Although, I run a website in production in a Docker container, (that is using node dist/server/entry.mjs), and there it does not work...

If the 404 page was prerendered, it may have been an issue introduced recently.

[xriter]

If the 404 page was prerendered, it may have been an issue introduced recently.

It uses the custom 404.astro, and no prerender variable was set. I believe it then always does SSR right?