Conversation
github-actions
bot
added
pkg: integration
![github-actions[bot]](https://avatars.gh.lumenfield.work/in/15368?s=60&v=4){kind=small}
CodSpeed Performance ReportMerging #13527 will not alter performanceComparing Summary
|
🦋 Changeset detectedLatest commit: 47fb9cf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
sarah11918
reviewed
Apr 7, 2025
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Just a few tiny suggestions here, changeset and config reference! Looking pretty sweet!
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
ematipico
approved these changes
Apr 8, 2025
sarah11918
approved these changes
Apr 9, 2025
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Approving for docs! 🥳
(Noting I did review the configuration-reference JSDoc and it looks fine to the eye here. We'll see for sure when it's pulled into docs proper.)
Merged
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> Co-authored-by: florian-lefebvre <69633530+florian-lefebvre@users.noreply.github.com> Co-authored-by: sarah11918 <5098874+sarah11918@users.noreply.github.com> Co-authored-by: ematipico <602478+ematipico@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR unflags the session API. Aside from removing the flag, this changes some of the details of how session configuration is validated, because of them no longer being opt-in. Previously, if a user had enabled the flag and not configured a driver we would throw when validating the config We can no longer do this because we don't know if the sessions will be used. Instead, we use a getter for the session object in context and the Astro global. Previously this would just be undefined. Now it also logs a warning if accessed, explaining why it is undefined. As well as doing this when there is no driver, it will catch attempts to access it in prerendered pages. This would previously fail with a headers error when it tried to set a cookie. It now fails earlier, with a more helpful error message.
Testing
The configuration tests have mostly been removed, as they no longer apply. Other tests have been updated to remove flags.
Docs
This will have a lot of docs changes, to come later.