Skip to content

Refactor: remove Deno shim to esbuild "banner"#3734

Merged
bholmesdev merged 4 commits intomainfrom
refactor/deno-shim-as-banner
Jun 27, 2022
Merged

Refactor: remove Deno shim to esbuild "banner"#3734
bholmesdev merged 4 commits intomainfrom
refactor/deno-shim-as-banner

Conversation

@bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Jun 27, 2022

Changes

  • Deno and Netlfy edge adapters: Add process shim using an esbuild banner instead of an ESM import. This guarantees our shim will appear at the top of the file!
  • Deno and Netlfy edge adapters: Remove shim.ts import

Testing

Make sure nothing fails 👍

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2022

🦋 Changeset detected

Latest commit: f758e48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/deno Patch
@astrojs/netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 27, 2022
@FredKSchott
Copy link
Member

Nice! I like this.

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪄

@bholmesdev bholmesdev merged commit 4acd245 into main Jun 27, 2022
@bholmesdev bholmesdev deleted the refactor/deno-shim-as-banner branch June 27, 2022 21:20
@astrobot-houston astrobot-houston mentioned this pull request Jun 27, 2022
ematipico pushed a commit that referenced this pull request Feb 6, 2025
* refactor: remove Deno shim to esbuild "banner"

* refactor: move shim to const

* refactor: add shim to netlify edge

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants