Conversation
🦋 Changeset detectedLatest commit: 43df66a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This will fix #4834 |
e9a03e0 to
d3ce462
Compare
|
Hi @matthewp - we've taken a look at this for Docs and the inline docs you've written here wouldn't end up on the docs page. As this PR stands, this would mean nothing ends up in Docs. So, nothing holds this PR up, but we would want an accompanying Docs PR to the API reference page so that when the release goes out, there's at least something minimal there corresponding to the new feature in the changelog. I think we would want to take what you've got in the RFC and split that content up into an entry for the API reference page and... some other page? Can we figure out what's the minimum that needs to go on API reference, consistent with the other entries there, and get that ready to merge with this PR in a Docs PR? Then, we can take the rest of the great content in the RFC and figure out a place for it. |
sarah11918
left a comment
There was a problem hiding this comment.
Nothing in this PR that docs needs to review, but we've requested a Docs PR in another comment!
delucis
left a comment
There was a problem hiding this comment.
Looks good @matthewp! Like Sarah, I think a summary of the API in the API Reference (maybe after Astro.response?) would be a good start.
Additional good spots for docs:
- SSR features: https://docs.astro.build/en/guides/server-side-rendering/#features
- Our upcoming endpoints guide that @Jutanium is working on
515690c to
43df66a
Compare
Today is minor release day!
* Astro.cookies implementation * Remove unused var * Fix build * Add a changesetp * Remove spoken-word expires
* Astro.cookies implementation * Remove unused var * Fix build * Add a changesetp * Remove spoken-word expires
* Astro.cookies implementation * Remove unused var * Fix build * Add a changesetp * Remove spoken-word expires
* Astro.cookies implementation * Remove unused var * Fix build * Add a changesetp * Remove spoken-word expires
* Astro.cookies implementation * Remove unused var * Fix build * Add a changesetp * Remove spoken-word expires
Changes
Testing
Docs