Merged
Conversation
🦋 Changeset detectedLatest commit: fc51dd8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1c7cd11 to
d278f94
Compare
matthewp
reviewed
Nov 4, 2022
matthewp
reviewed
Nov 4, 2022
matthewp
reviewed
Nov 4, 2022
matthewp
reviewed
Nov 4, 2022
100b9cc to
d2cbfbb
Compare
8a85edc to
05f1f43
Compare
05f1f43 to
6229c2a
Compare
b13936a to
4096f79
Compare
4096f79 to
8cc5f19
Compare
d87457a to
0ee8aef
Compare
Member
Author
|
!preview prerender |
Contributor
|
0ee8aef to
e2570dd
Compare
Member
Author
|
!preview prerender |
Contributor
|
Member
Author
|
!preview prerender |
Contributor
|
af456e7 to
247c937
Compare
Member
Author
|
!preview prerender |
Contributor
|
matthewp
reviewed
Dec 16, 2022
matthewp
reviewed
Dec 16, 2022
matthewp
reviewed
Dec 16, 2022
bholmesdev
approved these changes
Dec 16, 2022
Contributor
bholmesdev
left a comment
There was a problem hiding this comment.
Nonblocking comment on code reuse. But the features this unlocks have prerendered me speechless 😶
matthewp
approved these changes
Dec 16, 2022
delucis
reviewed
Dec 16, 2022
Member
delucis
left a comment
There was a problem hiding this comment.
Left a couple wording tweaks on the types/errors, but otherwise LGTM 👍
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
delucis
approved these changes
Dec 16, 2022
Merged
ematipico
pushed a commit
that referenced
this pull request
Feb 6, 2025
* wip: hybrid output * wip: hybrid output mvp * refactor: move hybrid => server * wip: hybrid support for `output: 'server'` * feat(hybrid): overwrite static files * fix: update static build * feat(hybrid): skip page generation if no static entrypoints * feat: migrate from hybrid output => prerender flag * fix: appease typescript * fix: appease typescript * fix: appease typescript * fix: appease typescript * fix: improve static cleanup * attempt: avoid preprocess scanning * hack: force generated .js files to be treated as ESM * better handling for astro metadata * fix: update scanner plugin * fix: page name bug * fix: keep ssr false when generating pages * fix: force output to be treated as ESM * fix: client output should respect buildConfig * fix: ensure outDir is always created * fix: do not replace files with noop * fix(netlify): add support for `experimental_prerender` pages * feat: switch to `experimental_prerender` * chore: update es-module-lexer code in test * feat: improved code-splitting, cleanup * feat: move prerender behind flag * test: prerender * test: update prerender test * chore: update lockfile * fix: only match `.html` files when resolving assets * chore: update changeset * chore: remove ESM hack * chore: allow `--experimental-prerender` flag, move `--experimental-error-overlay` into subobject * chore: update changeset * test(vite-plugin-scanner): add proper unit tests for vite-plugin-scanner * chore: remove leftover code * chore: add comment on cleanup task * refactor: move manual chunks logic to vite-plugin-prerender * fix: do not support let declarations * test: add var test * refactor: prefer existing util * Update packages/astro/src/@types/astro.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/core/errors/errors-data.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/@types/astro.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> Co-authored-by: Nate Moore <nate@astro.build> Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
output: 'server'to prerender any page to static HTML.experimentalflag,prerenderto opt-in to this behavior.export const prerender = true;to any file in thepages/directory. These assets will be statically rendered at build time and included as assets.Testing
Tests have been added to verify this mode's output and the shape of the manifest. It's a bit difficult to test directly since our adapters are not responsible for serving static assets.
Docs
Still a WIP, will be working on these after the change lands!