feat: change path into assets#5584
Conversation
🦋 Changeset detectedLatest commit: f48ccdf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
Thank you @wulinsheng123! I’ll leave it to more expert eyes to review this properly.
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
This LGTM! We decided to do an additional change and output to an _astro directory instead of assets, but I can make that change on top of these.
Many thanks for the PR!
|
@natemoo-re maybe we should make those changes directly in this PR so we have one changeset that doesn't mention this intermediate change 🤔 |
natemoo-re
force-pushed
the
chunk
branch
2 times, most recently
from
4a1eeca to
f48ccdf
Compare
|
@bluwy I was going to do that, but I think my changes will be quite involved. I'll be sure to update the changelog in my PR as well. |
* feat: change path * feat: fix bug #5502 * fix: astro fix to patch * feat: change to major * chore: update changelog * fix: change entryFileNames into assets folder * fix: fix error message in test Co-authored-by: bluwy <bjornlu.dev@gmail.com>
6 participants
Changes
fix bug #5502
Testing
Docs