Conversation
🦋 Changeset detectedLatest commit: b27537d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
bholmesdev
left a comment
bholmesdev
left a comment
There was a problem hiding this comment.
A couple questions before merging. Really deprappreciate this!
aFuzzyBear
left a comment
aFuzzyBear
left a comment
There was a problem hiding this comment.
Its a sad PR this one, but needed, thank you for doing this @bluwy great bit of housekeeping 🧹
| glob: createAstroGlobFn(), | ||
| // INVESTIGATE is there a use-case for multi args? | ||
| // TODO remove in 2.0 | ||
| resolve(...segments: string[]) { |
There was a problem hiding this comment.
Ah Astro.resolve I mind when you came in, and then boom it was used everywhere, prior to the shift to esm.
RIP
| site, | ||
| site: site ? new URL(site) : undefined, | ||
| generator: `Astro v${ASTRO_VERSION}`, | ||
| fetchContent: createDeprecatedFetchContentFn(), |
There was a problem hiding this comment.
Astro.fetchContent another fan favorite, way before Astro.glob got better, this was the trick used on almost every Astro site <0.24.
RIP...
|
Could we look into the smoke test, Im not familiar with this part of the process, but having re-ran them its saying on the docs build an external dep is missing its |
|
@aFuzzyBear we just merged a fix! Needs a rebase and we're golden 🐻 |
It was deprecated but it has been removed in v2.0.0 (see withastro/astro#5707). I think it should not be displayed in the reference anymore since we are now at v4.12.1
It was deprecated but it has been removed in v2.0.0 (see withastro/astro#5707). I think it should not be displayed in the reference anymore since we are now at v4.12.1
* Remove deprecated Astro globals * Remove deprecated hook param * Fix test * Add changeset * Add TODO
* Remove deprecated Astro globals * Remove deprecated hook param * Fix test * Add changeset * Add TODO
* Remove deprecated Astro globals * Remove deprecated hook param * Fix test * Add changeset * Add TODO
* Remove deprecated Astro globals * Remove deprecated hook param * Fix test * Add changeset * Add TODO
* Remove deprecated Astro globals * Remove deprecated hook param * Fix test * Add changeset * Add TODO
5 participants
Changes
Astro.resolve,Astro.fetchContent, andAstro.canonicalURL.buildConfigoption parameter from integrationastro:build:starthookThe changesets have more information.
Testing
Existing tests should pass (made some tweaks to the old APIs)
Docs
Needs a review of the changeset description.