feat(@astrojs/netlify): add build.split support#7615
Merged
Conversation
🦋 Changeset detectedLatest commit: c42b3dc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
sarah11918
approved these changes
Jul 10, 2023
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Two copy-paste names to address, otherwise, Docs is fine with this! 😄
bluwy
approved these changes
Jul 11, 2023
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
LGTM. Also confirmed that changesets would auto-bump the underscore-redirects dep for the dependants on release.
| './fixtures/split-support/.netlify/functions-internal/src/pages/entry.index.astro.mjs', | ||
| import.meta.url | ||
| ); | ||
| const { handler } = await import(entryURL); |
Member
There was a problem hiding this comment.
The test seems to fail in windows here. using entryURL.toString() or entryURL.href should fix it I think.
Member
There was a problem hiding this comment.
Looks like it didn't work 🤔 The string should start with file:// on Windows since C:\ or D:\ looks like a protocol to node.
ematipico
force-pushed
the
feat/netlify-split-support
branch
2 times, most recently
from
a35d7a5 to
6f086fd
Compare
github-actions
bot
added
the
pkg: astro
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
ematipico
force-pushed
the
feat/netlify-split-support
branch
from
547e70f to
b3a4fcc
Compare
github-actions
bot
removed
the
pkg: astro
ematipico
force-pushed
the
feat/netlify-split-support
branch
3 times, most recently
from
c256547 to
235a915
Compare
ematipico
force-pushed
the
feat/netlify-split-support
branch
5 times, most recently
from
b009466 to
fedd0fa
Compare
ematipico
force-pushed
the
feat/netlify-split-support
branch
4 times, most recently
from
916564f to
3365840
Compare
github-actions
bot
added
the
pkg: astro
ematipico
force-pushed
the
feat/netlify-split-support
branch
from
3365840 to
1d52532
Compare
github-actions
bot
removed
the
pkg: astro
ematipico
force-pushed
the
feat/netlify-split-support
branch
2 times, most recently
from
179db59 to
35491aa
Compare
ematipico
force-pushed
the
feat/netlify-split-support
branch
from
35491aa to
c42b3dc
Compare
bluwy
approved these changes
Jul 13, 2023
Merged
ematipico
added a commit
that referenced
this pull request
Feb 6, 2025
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
ematipico
added a commit
that referenced
this pull request
Feb 7, 2025
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds
build.splitsupport for the@astrojs/netlifyadapter.List of changes:
@astrojs/underscore-redirectspayload to accept aMapinstead of an array of routes and a dynamic target. This logically makes more sense compared to the previous logic, because a route is mapped to a dynamic target (even though we could have duplicates);@astrojs/underscore-redirectsallowed me to create redirects correctly usingRouteData->URLentry pointTesting
Added new test cases
Docs
Updated the
README.mdand added a changeset. It's a copy-paste from the Vercel one./cc @withastro/maintainers-docs for feedback!