Ensure dev server restart respects base removal#8027
Merged
natemoo-re merged 4 commits intomainfrom Aug 10, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 3e1a5a7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
natemoo-re
commented
Aug 10, 2023
| @@ -1,5 +1,4 @@ | |||
| import { escape } from 'html-escaper'; | |||
| import { baseCSS } from './css.js'; | |||
Member
Author
There was a problem hiding this comment.
This is unrelated cleanup, but I was in this file so it made sense
Comment on lines
-47
to
+51
| if (settings.config.base !== '/') { | ||
| viteServer.middlewares.stack.unshift({ | ||
| route: '', | ||
| handle: baseMiddleware(settings, logging), | ||
| }); | ||
| } | ||
| // fix(#6067): always inject this to ensure zombie base handling is killed after restarts | ||
| viteServer.middlewares.stack.unshift({ | ||
| route: '', | ||
| handle: baseMiddleware(settings, logging), | ||
| }); |
Member
Author
There was a problem hiding this comment.
Actual change is just removing the if check for settings.config.base !== '/'
matthewp
approved these changes
Aug 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
basemiddleware should always be injected, even if the base is set to the defaultbaseis removedTesting
Tested manually since it's HMR/restart behavior
Docs
N/A, bug fix only