improve naming of new adapter api by florian-lefebvre · Pull Request #13253 · withastro/docs

florian-lefebvre · 2026-02-11T09:03:52Z

Description (required)

Related issues & labels (optional)

Closes #
Suggested label:

For Astro version: `6.x`. See astro PR #15461.

netlify · 2026-02-11T09:04:00Z

✅ Deploy Preview for astro-docs-2 ready!

Name	Link
🔨 Latest commit	`8452e19`
🔍 Latest deploy log	https://app.netlify.com/projects/astro-docs-2/deploys/6993314473411c00075f26a9
😎 Deploy Preview	https://deploy-preview-13253--astro-docs-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

astrobot-houston · 2026-02-11T09:04:17Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
en/guides/upgrade-to/v6.mdx	Localization changed, will be marked as complete.
en/reference/adapter-reference.mdx	Source changed, localizations will be marked as outdated.

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

src/content/docs/en/guides/upgrade-to/v6.mdx

ArmandPhilippot

This is a quick review because there is something I find confusing (see my long comment...) and I think I need to better understand that before doing a more thorough review! 😄 But, overall, this looks good!

src/content/docs/en/guides/upgrade-to/v6.mdx

src/content/docs/en/reference/adapter-reference.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

ArmandPhilippot

Thanks again for the explanation, this is much clearer now! I left a few more suggestions, then this seems in a good shape to me.

I know the deprecation is not yet acted, but if this is deprecated... are we sure this will be removed in Astro 7? I mean this could be deprecated but we decide to wait longer (Astro 8) because some edge cases may arise. (I'm asking this because of all the "Astro 7.0 preview")

src/content/docs/en/guides/upgrade-to/v6.mdx

src/content/docs/en/reference/adapter-reference.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

florian-lefebvre · 2026-02-12T08:50:38Z

Matthew approved the code PR so the deprecation is validated

ArmandPhilippot

Looks good to me, I only left suggestions about the asides (cautions instead of tips, and maybe they can be reworded now that args and exports are also deprecated).

src/content/docs/en/reference/adapter-reference.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

ArmandPhilippot · 2026-02-12T15:52:28Z

src/content/docs/en/reference/adapter-reference.mdx

-  });
-}
-```
+**Type:** `() => App`


And just a reminder that if/when withastro/astro#15483 is approved, we would need to update that too!

I think ideally it would be better to merge this PR (and associated code PR) first, then make another docs PR for streaming

sarah11918

Nice work Florian (and Armand)! I didn't preview e.g. the updates to the line highlighting in favour of simply tackling the text. See what you think of my comments!

src/content/docs/en/guides/upgrade-to/v6.mdx

src/content/docs/en/reference/adapter-reference.mdx

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

src/content/docs/en/guides/upgrade-to/v6.mdx

florian-lefebvre · 2026-02-16T14:01:55Z

Bump!

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

src/content/docs/en/guides/upgrade-to/v6.mdx

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

src/content/docs/en/guides/upgrade-to/v6.mdx

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

src/content/docs/en/reference/adapter-reference.mdx

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

sarah11918 · 2026-02-16T14:46:36Z

OK, as long as my last change looks good in the deploy preview (visually), this will be fine! Moving on to changesets!

sarah11918

LGTM! 🎉

src/content/docs/en/guides/upgrade-to/v6.mdx

rename

0ac71f3

florian-lefebvre mentioned this pull request Feb 11, 2026

feat: improve naming of new adapter api withastro/astro#15461

Merged

3 tasks

florian-lefebvre added 3 commits February 11, 2026 10:23

wip

dc75921

wip

7ee69a3

wip

14e85bd

florian-lefebvre marked this pull request as ready for review February 11, 2026 10:08

sarah11918 reviewed Feb 11, 2026

View reviewed changes

src/content/docs/en/guides/upgrade-to/v6.mdx Outdated Show resolved Hide resolved

fix link

f654676

ArmandPhilippot reviewed Feb 11, 2026

View reviewed changes

Update src/content/docs/en/guides/upgrade-to/v6.mdx

464f374

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

ArmandPhilippot reviewed Feb 11, 2026

View reviewed changes

florian-lefebvre and others added 7 commits February 12, 2026 09:31

Merge branch 'v6' into feat/new-adapter-api-better-naming

b65d640

Apply suggestions from code review

665ebd1

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

Apply suggestions from code review

0f34405

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

feedback

080afae

feedback

e68a1ba

feedback

877566a

feedback

06472ef

florian-lefebvre requested review from ArmandPhilippot and sarah11918 February 12, 2026 08:50

ArmandPhilippot added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) 6.0 labels Feb 12, 2026

feedback

9298541

florian-lefebvre mentioned this pull request Feb 12, 2026

feat: add streaming arg to createApp() withastro/astro#15483

Merged

ArmandPhilippot reviewed Feb 12, 2026

View reviewed changes

src/content/docs/en/reference/adapter-reference.mdx Outdated Show resolved Hide resolved

src/content/docs/en/reference/adapter-reference.mdx Outdated Show resolved Hide resolved

src/content/docs/en/reference/adapter-reference.mdx Outdated Show resolved Hide resolved

Apply suggestion from @ArmandPhilippot

acc1566

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

ArmandPhilippot reviewed Feb 12, 2026

View reviewed changes

feedback

3c0ddab

sarah11918 reviewed Feb 12, 2026

View reviewed changes

florian-lefebvre and others added 2 commits February 13, 2026 08:36

Apply suggestions from code review

56a910e

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

Update src/content/docs/en/reference/adapter-reference.mdx

a499b93

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

florian-lefebvre commented Feb 13, 2026

View reviewed changes

src/content/docs/en/guides/upgrade-to/v6.mdx Show resolved Hide resolved

florian-lefebvre requested a review from sarah11918 February 16, 2026 09:24

florian-lefebvre mentioned this pull request Feb 16, 2026

feat: deprecate NodeApp #13271

Merged

florian-lefebvre and others added 4 commits February 16, 2026 15:26

Update src/content/docs/en/guides/upgrade-to/v6.mdx

bb98c3c

wip

c4cb2e9

Update src/content/docs/en/reference/adapter-reference.mdx

d3b9317

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

wip

e45e77b

sarah11918 reviewed Feb 16, 2026

View reviewed changes

src/content/docs/en/guides/upgrade-to/v6.mdx Show resolved Hide resolved

Update src/content/docs/en/guides/upgrade-to/v6.mdx

7e5b6e2

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

sarah11918 reviewed Feb 16, 2026

View reviewed changes

src/content/docs/en/guides/upgrade-to/v6.mdx Outdated Show resolved Hide resolved

Update src/content/docs/en/guides/upgrade-to/v6.mdx

cd878dc

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

sarah11918 reviewed Feb 16, 2026

View reviewed changes

src/content/docs/en/reference/adapter-reference.mdx Outdated Show resolved Hide resolved

Update src/content/docs/en/reference/adapter-reference.mdx

48b091a

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

sarah11918 approved these changes Feb 16, 2026

View reviewed changes

florian-lefebvre commented Feb 16, 2026

View reviewed changes

src/content/docs/en/guides/upgrade-to/v6.mdx Outdated Show resolved Hide resolved

Update src/content/docs/en/guides/upgrade-to/v6.mdx

8452e19

sarah11918 added this to the v6.0.0 docs milestone Feb 16, 2026

florian-lefebvre merged commit 2cef977 into v6 Feb 16, 2026
10 checks passed

florian-lefebvre deleted the feat/new-adapter-api-better-naming branch February 16, 2026 15:48

This was referenced Feb 17, 2026

feat: add streaming arg to createApp() #13273

Merged

feat: update edgeMiddleware references to middlewareMode #13277

Merged

Uh oh!

Conversation

florian-lefebvre commented Feb 11, 2026

Description (required)

Related issues & labels (optional)

For Astro version: 6.x. See astro PR #15461.

Uh oh!

netlify bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for astro-docs-2 ready!

Uh oh!

astrobot-houston commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

Uh oh!

ArmandPhilippot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ArmandPhilippot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

florian-lefebvre commented Feb 12, 2026

Uh oh!

ArmandPhilippot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ArmandPhilippot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

florian-lefebvre Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

sarah11918 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

florian-lefebvre commented Feb 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarah11918 commented Feb 16, 2026

Uh oh!

sarah11918 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

For Astro version: `6.x`. See astro PR #15461.

netlify bot commented Feb 11, 2026 •

edited

Loading

astrobot-houston commented Feb 11, 2026 •

edited

Loading