chore: replace picocolors with builtins#2210
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4b44195 to
7e6a2eb
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
==========================================
+ Coverage 76.18% 76.27% +0.08%
==========================================
Files 116 116
Lines 3103 3106 +3
Branches 689 691 +2
==========================================
+ Hits 2364 2369 +5
+ Misses 656 655 -1
+ Partials 83 82 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
7e6a2eb to
d5193e9
Compare
|
After #2246, i think wrapper is unnecessary layer of abstraction here, and IMO, we can use it directly, as @aklinker1 suggested. Are you agree @eupthere ? |
- Removed `picocolors` dependency from wxt package. - Introduced a new `color` utility for text styling. - Updated all instances of `picocolors` to use the new `color` utility.
d5193e9 to
5abc3b8
Compare
|
@aklinker1 I added the wrapper to preserve the picocolor style API, but I agree it’s not really needed. Using styleText directly is simpler. I'm happy to drop the wrapper! |
|
@PatrykKuniczak can you please update PRs with a merge commit rather than a rebase and force push? It throws off everyone's history if multiple people are working on a branch. |
|
Thanks for helping make WXT better! |
No problem |
Co-authored-by: Aaron <aaronklinker1@gmail.com>
Overview
picocolorsdependency fromwxtpackage.colorutility for text styling.picocolorsto use the newcolorutility.Manual Testing
Results
Related Issue
This PR closes #2180