Skip to content

fix: add Firefox action manifest typings#2217

Merged
aklinker1 merged 1 commit intowxt-dev:mainfrom
VaughnBosu:fix/firefox-action-manifest-typing
Apr 12, 2026
Merged

fix: add Firefox action manifest typings#2217
aklinker1 merged 1 commit intowxt-dev:mainfrom
VaughnBosu:fix/firefox-action-manifest-typing

Conversation

@VaughnBosu
Copy link
Copy Markdown
Contributor

Overview

Added FirefoxActionManifestOptions interface with browser_style, default_area, and theme_icons, and applied it to action, browser_action, and page_action in UserManifest.

Manual Testing

  • pnpm test run manifest passes

  • Added default_area and theme_icons to wxt-demo/wxt.config.ts — no type errors, and the values appeared in the built manifest.json

Related Issue

This PR closes #2096

@VaughnBosu VaughnBosu requested a review from aklinker1 as a code owner March 31, 2026 22:57
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 31, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 241e339
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69dbfd814170ab00083d2560
😎 Deploy Preview https://deploy-preview-2217--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Mar 31, 2026
Comment thread packages/wxt/src/types.ts Outdated
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 1, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2217

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2217

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2217

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2217

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2217

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2217

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2217

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2217

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2217

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2217

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2217

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2217

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2217

wxt

npm i https://pkg.pr.new/wxt@2217

commit: 241e339

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (2a21279) to head (241e339).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2217      +/-   ##
==========================================
- Coverage   76.66%   76.60%   -0.07%     
==========================================
  Files         117      117              
  Lines        3163     3163              
  Branches      711      711              
==========================================
- Hits         2425     2423       -2     
- Misses        656      658       +2     
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PatrykKuniczak PatrykKuniczak force-pushed the fix/firefox-action-manifest-typing branch from 3f45907 to 40d54d5 Compare April 1, 2026 21:56
@PatrykKuniczak PatrykKuniczak enabled auto-merge (squash) April 1, 2026 21:56
Comment thread packages/wxt/src/types.ts Outdated
Comment on lines +968 to +969
page_action?: Browser.runtime.ManifestV2['page_action'] &
FirefoxActionManifestOptions;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/wxt-dev/wxt/pull/2217/changes#r3020254936

If browser_style isn't supported on the action, seems like we shouldn't create a shared type if all 3 are different.

auto-merge was automatically disabled April 12, 2026 20:15

Head branch was pushed to by a user without write access

@VaughnBosu VaughnBosu force-pushed the fix/firefox-action-manifest-typing branch from 40d54d5 to 241e339 Compare April 12, 2026 20:15
@aklinker1 aklinker1 enabled auto-merge (squash) April 12, 2026 20:28
@aklinker1 aklinker1 merged commit a008426 into wxt-dev:main Apr 12, 2026
18 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for helping make WXT better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firefox: in manifest, support default_area and theme_icons in action

3 participants