fix: add Firefox action manifest typings#2217
Merged
aklinker1 merged 1 commit intowxt-dev:mainfrom Apr 12, 2026
Merged
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2217 +/- ##
==========================================
- Coverage 76.66% 76.60% -0.07%
==========================================
Files 117 117
Lines 3163 3163
Branches 711 711
==========================================
- Hits 2425 2423 -2
- Misses 656 658 +2
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PatrykKuniczak
approved these changes
Apr 1, 2026
3f45907 to
40d54d5
Compare
aklinker1
requested changes
Apr 12, 2026
Comment on lines
+968
to
+969
| page_action?: Browser.runtime.ManifestV2['page_action'] & | ||
| FirefoxActionManifestOptions; |
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
https://github.com/wxt-dev/wxt/pull/2217/changes#r3020254936
If browser_style isn't supported on the action, seems like we shouldn't create a shared type if all 3 are different.
auto-merge was automatically disabled
April 12, 2026 20:15
Head branch was pushed to by a user without write access
40d54d5 to
241e339
Compare
aklinker1
approved these changes
Apr 12, 2026
Contributor
|
Thanks for helping make WXT better! |
aklinker1
pushed a commit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added FirefoxActionManifestOptions interface with browser_style, default_area, and theme_icons, and applied it to action, browser_action, and page_action in UserManifest.
Manual Testing
pnpm test run manifest passes
Added default_area and theme_icons to wxt-demo/wxt.config.ts — no type errors, and the values appeared in the built manifest.json
Related Issue
This PR closes #2096