This repository was archived by the owner on Jul 26, 2021. It is now read-only.
Closed
Conversation
handle bool instead of string in 'isuserdefined' reponse fields (API change 4.11.1) handle 'forced' option in deleteTemplate change default sync operation timeout handle iptonetwork parameter of deployVirtualMachine as a list
Member
|
Thanks for the PR @psycofdj! Unfortunately it seems you missed this line in the README: Or maybe you didn’t miss it, but is the line not clear enough. The important word here is All the code in this package is automatically generated using the code in the So that means that any code changes should be made in there and not directly in the So I’m afraid that I cannot merge this PR. If you still want to contribute the fixes, then please look at the I’ll be happy to merge a PR for that! |
Author
|
Me bad, I missed it indded. I'm looking at this and see what is possible to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TemplateService
Proper handle of 'getUploadParamsForTemplate' response
Despite documentation, cloudstack actually returns an intermediate structure
getuploadparamsingetUploadParamsForTemplatereponse.Affected endpoints:
Add missing
forcedoption in deleteTemplate parametersAffected endpoints:
Handle bool instead of string in 'isuserdefined' reponse fields.
This breaking change was brought in cloudstack in version 4.11.1.0 as described in their pull request and release note. The PR offers an implementation that ensure backwark compatibility with strings fields.
Affected endpoints:
VirtualMachineService
Handle
iptonetworklistparameter of deployVirtualMachine as a list of propertiesAs pointed out in iptonetworklist serialization #87,
iptonetworklistis improperly constructed. The PR changes the attribute to a list of map which is serialized asiptonetworklist[<index>].<key>=<value>Affected endpoints:
Other
Change default http timeout used in sync operations
Default timeout of
60 secondscan be a little low for synchroneus operations likeenableStaticNatunder heavy load. The PR changes it to5 minues