This repository was archived by the owner on Jul 26, 2021. It is now read-only.
Update secondarystoragetotal field to float64 for Cloudstack 4.11.1.0#101
Merged
svanharmelen merged 1 commit intoxanzy:masterfrom Aug 27, 2018
Merged
Conversation
After Cloudstack 4.11.1.0 the secondarystoragetotal field was changed from Long to Float in Cloudstack in apache/cloudstack#2439. Changing this in the generated client seems safe and backward compatible because long values will still be parsed correctly as a float64.
Member
|
LGTM! Thanks @cezarsa! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After Cloudstack 4.11.1.0 the secondarystoragetotal field was changed from Long to Float in Cloudstack in apache/cloudstack#2439.
Changing this in the generated client seems safe and backward compatible because long values will still be parsed correctly as a float64.