Conversation
thekid
added a commit
to xp-forge/mongodb
that referenced
this pull request
May 18, 2023
thekid
added a commit
to xp-forge/sessions
that referenced
this pull request
May 18, 2023
thekid
added a commit
to xp-framework/compiler
that referenced
this pull request
May 18, 2023
thekid
added a commit
to xp-forge/frontend
that referenced
this pull request
May 18, 2023
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code that asserts using
preg_match()does not produce meaningful error messages:This pull request solves the problem by adding a matches shorthand method which uses the
test.assert.Matchesclass.Usage
The pattern is included in the assertion error message:
Errors
If
preg_match()returns an error, an exception is raised. Its stacktrace includes the error message