Skip to content

Use Node 14 + MSVC 2017#447

Merged
captainsafia merged 3 commits intozeromq:5.xfrom
aminya:5.x
Apr 15, 2021
Merged

Use Node 14 + MSVC 2017#447
captainsafia merged 3 commits intozeromq:5.xfrom
aminya:5.x

Conversation

@aminya
Copy link
Copy Markdown
Member

@aminya aminya commented Apr 14, 2021

The v8_enable_pointer_compression failure seems to be fixed on Node 14

nodejs/node#33688
prebuild/prebuild#268 (comment)
prebuild/prebuildify#37

@aminya
Copy link
Copy Markdown
Member Author

aminya commented Apr 14, 2021

@captainsafia Another try. We got this! 🤞🏻

@captainsafia
Copy link
Copy Markdown
Contributor

Third times the charm!

Once we've got all this sorted out, we should take a look at migrating this repo to use Github Actions. Perhaps as part of https://github.com/nteract/nteract/issues/5500.

@captainsafia captainsafia merged commit 13d65ca into zeromq:5.x Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants