feat: add CONTRIBUTING.md and structural PR validation CI#62
Open
sendtoshailesh wants to merge 1 commit intomainfrom
Open
feat: add CONTRIBUTING.md and structural PR validation CI#62sendtoshailesh wants to merge 1 commit intomainfrom
sendtoshailesh wants to merge 1 commit intomainfrom
Conversation
Implements scope of #17 (de-scoped): - CONTRIBUTING.md: skill contribution guide, SKILL.md schema, PR process, Code of Conduct link - .github/workflows/pr-validation.yml: structural validation + markdownlint on every PR - scripts/validate-structure.js: frontmatter, naming, cross-reference, link, and section checks - .markdownlint.json: shared lint config The eval framework (originally section 3 of #17) is split out to #61 and is not part of this PR. Supersedes #40.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17.
Adds a contributor guide and a structural PR validation pipeline so community skill contributions can be verified automatically.
This is a re-scoped replacement for #40, which mixed three concerns. The exploratory eval framework portion has been split into #61 and intentionally excluded from this PR.
Changes
CONTRIBUTING.md— skill contribution guide (directory structure,SKILL.mdfrontmatter schema, naming conventions), maintainer-curated agent change process, PR process, and a link to the Microsoft Open Source Code of Conduct..github/workflows/pr-validation.yml— active workflow on every PR tomain:structure-checkjob runsscripts/validate-structure.js.markdownlintjob runs across*.md(excludingwebsite/node_modules,website/build,website/docs).scripts/validate-structure.js— checks frontmatter required fields, name-directory consistency, kebab-case directory naming,SKILL.mdpresence, required sections (## When to Use,## Procedure;## Warningfor agents), agent/skill cross-reference integrity, and relative-link resolution..markdownlint.json— shared lint config.All checks pass against the current repo state.
What is not in this PR
The Agent/Skill eval framework (originally section 3 of #17) is tracked separately in #61 and is intentionally out of scope here. The earlier spike under
evals/from #40 is not carried over; #61 will revisit it from scratch.Acceptance criteria mapping (#17, reduced scope)
CONTRIBUTING.mdexists with clear skill contribution guidelines andSKILL.mdschema..yml, not.example.yml).Notes for reviewers
CONTRIBUTING.md).Related