Skip to content

Remove deprecated internal spanBuilder methods#11287

Draft
amarziali wants to merge 1 commit intomasterfrom
andrea.marziali/deprecate
Draft

Remove deprecated internal spanBuilder methods#11287
amarziali wants to merge 1 commit intomasterfrom
andrea.marziali/deprecate

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@amarziali amarziali added type: enhancement Enhancements and improvements comp: core Tracer core labels May 6, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 6, 2026

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1778059610 1778059956
end_time 2026-05-06T09:28:15 2026-05-06T09:34:01
git_branch master andrea.marziali/deprecate
git_commit_sha 6ab3100 c595015
start_time 2026-05-06T09:26:51 2026-05-06T09:32:37
See matching parameters
Baseline Candidate
ci_job_id 1660141455 1660141455
ci_pipeline_id 111683324 111683324
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1778058962 1778058962

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-22356.617ns; +23657.770ns] or [-7.657%; +8.102%]
unstable
[-32.514µs; +35.233µs] or [-9.731%; +10.544%]
unstable
[-41.466µs; +47.445µs] or [-11.870%; +13.581%]
unstable
[-104.068µs; +111.549µs] or [-8.615%; +9.234%]
same
scenario:basic same same same unstable
[+32.440µs; +259.987µs] or [+3.100%; +24.845%]
same
scenario:loop same same unsure
[+6.188µs; +16.515µs] or [+0.068%; +0.182%]
same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (334.148 µs) : 306, 362
.   : milestone, 334,
basic (295.659 µs) : 289, 303
.   : milestone, 296,
loop (8.985 ms) : 8980, 8991
.   : milestone, 8985,
section candidate
noprobe (335.507 µs) : 300, 371
.   : milestone, 336,
basic (297.226 µs) : 290, 304
.   : milestone, 297,
loop (8.991 ms) : 8986, 8996
.   : milestone, 8991,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 334.148 µs [306.197 µs, 362.099 µs]
basic 295.659 µs [288.653 µs, 302.665 µs]
loop 8.985 ms [8.98 ms, 8.991 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 335.507 µs [299.54 µs, 371.475 µs]
basic 297.226 µs [290.293 µs, 304.159 µs]
loop 8.991 ms [8.986 ms, 8.996 ms]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant