Fix: Prevent duplicate percentage values when switching between mobile and desktop in Tech Report#1140
Merged
tunetheweb merged 4 commits intomainfrom Oct 15, 2025
Merged
Conversation
…updateAppSummary Co-authored-by: max-ostapenko <1611259+max-ostapenko@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix percentage appending issue when changing states
Fix: Prevent duplicate percentage values when switching between mobile and desktop in Tech Report
Oct 15, 2025
tunetheweb
requested changes
Oct 15, 2025
tunetheweb
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When switching between mobile and desktop client views on the Tech Report page, percentage change indicators were being appended instead of replaced. This caused multiple percentage values to accumulate and display together, as shown in the issue screenshots.
For example, switching from mobile to desktop would result in displays like:
▼ -2.67% ▲ 5.26% ▼ -2.67% ▲ 5.26% ▼ -2.67%(instead of just the desktop values)Root Cause
In the
updateAppSummary()method insrc/js/techreport/timeseries.js, when the client breakdown was changed, new monthchange span elements were being appended to breakdown cards without first removing the existing ones:This is different from the
updateClientSummary()method, which clears the entire container (container.innerHTML = '') before rebuilding, preventing this issue.Solution
Added cleanup logic to remove any existing
.monthchangeelement before appending the new one:This ensures that only one percentage change indicator is displayed at a time, regardless of how many times the user switches between mobile and desktop views.
Testing
Fixes the issue where percentage values were appended instead of replaced when changing client breakdown state.
Original prompt
Fixes #1139
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.