Skip to content

Fix: Prevent duplicate percentage values when switching between mobile and desktop in Tech Report #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tunetheweb merged 4 commits into from
Oct 15, 2025
Merged

Fix: Prevent duplicate percentage values when switching between mobile and desktop in Tech Report #1140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92e1094
Initial plan
Copilot Oct 15, 2025
fa17ae0
Fix: Remove existing monthchange element before appending new one in …
Copilot Oct 15, 2025
6afad50
Better implementation
tunetheweb Oct 15, 2025
9442335
Pin super linter
tunetheweb Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-website.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Use more complete checks for generated HTML linting
run: cp -f .github/linters/.htmlhintrc_morechecks .github/linters/.htmlhintrc
- name: Lint Generated HTML
uses: super-linter/super-linter/slim@v8
uses: super-linter/super-linter/slim@v8.1.0
env:
DEFAULT_BRANCH: main
FILTER_REGEX_INCLUDE: static/html/.*
Expand Down
10 changes: 8 additions & 2 deletions src/js/techreport/timeseries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,16 @@ class Timeseries {
const latestMoM = latestClient?.momPerc;
const latestMoMStr = latestClient?.momString;
const styling = UIUtils.getChangeStatus(latestMoM, changeMeaning);
const monthChange = document.createElement('span');

/* Add month change element if not already present */
let monthChange = card.querySelector('.monthchange');
if(!monthChange) {
monthChange = document.createElement('span');
card.appendChild(monthChange);
}

monthChange.textContent = latestMoMStr;
monthChange.className = `monthchange ${styling?.color} ${styling?.direction}`;
card.appendChild(monthChange);
}
}
});
Expand Down
Loading