[typescript] fix: explode: true should yield appended query params#19519
Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom Sep 4, 2024
Merged
Conversation
joscha
commented
Sep 3, 2024
joscha
commented
Sep 3, 2024
joscha
commented
Sep 3, 2024
joscha
commented
Sep 3, 2024
macjohnny
approved these changes
Sep 4, 2024
Member
macjohnny
left a comment
There was a problem hiding this comment.
thanks for your contribution!
6 tasks
Contributor
|
For anyone looking here, I just want to mention that this broke enum serialization in query parameter, but it is now fixed on master: #20210 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a query param is defined as:
for a
contextof['a','b','c']it serializes the query incorrectly as:?context=a,b,chowever, due to
explode: trueit should be:?context=a&context=b&context=c.The change in this PR makes sure that any query params with
explode: trueare serialized correctly.It also fixes the exploded serialization for
objecttypes.See example table here: https://swagger.io/docs/specification/serialization/#Query%20Parameters
PR checklist
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)