-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
[typescript] fix: explode: true should yield appended query params
#19519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
macjohnny
merged 2 commits into
OpenAPITools:master
from
joscha:joscha/fix-exploded-query-params
Sep 4, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| generatorName: typescript | ||
| outputDir: samples/openapi3/client/petstore/typescript/builds/explode-query | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/snakecase-discriminator.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/typescript | ||
| additionalProperties: | ||
| platform: node | ||
| npmName: ts-petstore-client | ||
| projectName: ts-petstore-client | ||
| moduleName: petstore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
samples/openapi3/client/petstore/typescript/builds/explode-query/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| dist |
23 changes: 23 additions & 0 deletions
23
samples/openapi3/client/petstore/typescript/builds/explode-query/.openapi-generator-ignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # OpenAPI Generator Ignore | ||
| # Generated by openapi-generator https://github.com/openapitools/openapi-generator | ||
|
|
||
| # Use this file to prevent files from being overwritten by the generator. | ||
| # The patterns follow closely to .gitignore or .dockerignore. | ||
|
|
||
| # As an example, the C# client generator defines ApiClient.cs. | ||
| # You can make changes and tell OpenAPI Generator to ignore just this file by uncommenting the following line: | ||
| #ApiClient.cs | ||
|
|
||
| # You can match any string of characters against a directory, file or extension with a single asterisk (*): | ||
| #foo/*/qux | ||
| # The above matches foo/bar/qux and foo/baz/qux, but not foo/bar/baz/qux | ||
|
|
||
| # You can recursively match patterns against a directory, file or extension with a double asterisk (**): | ||
| #foo/**/qux | ||
| # This matches foo/bar/qux, foo/baz/qux, and foo/bar/baz/qux | ||
|
|
||
| # You can also negate patterns with an exclamation (!). | ||
| # For example, you can ignore all files in a docs folder with the file extension .md: | ||
| #docs/*.md | ||
| # Then explicitly reverse the ignore rule for a single file: | ||
| #!docs/README.md |
82 changes: 82 additions & 0 deletions
82
samples/openapi3/client/petstore/typescript/builds/explode-query/.openapi-generator/FILES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| .gitignore | ||
| AnotherFakeApi.md | ||
| DefaultApi.md | ||
| FakeApi.md | ||
| FakeClassnameTags123Api.md | ||
| PetApi.md | ||
| README.md | ||
| StoreApi.md | ||
| UserApi.md | ||
| apis/AnotherFakeApi.ts | ||
| apis/DefaultApi.ts | ||
| apis/FakeApi.ts | ||
| apis/FakeClassnameTags123Api.ts | ||
| apis/PetApi.ts | ||
| apis/StoreApi.ts | ||
| apis/UserApi.ts | ||
| apis/baseapi.ts | ||
| apis/exception.ts | ||
| auth/auth.ts | ||
| configuration.ts | ||
| git_push.sh | ||
| http/http.ts | ||
| http/isomorphic-fetch.ts | ||
| index.ts | ||
| middleware.ts | ||
| models/AdditionalPropertiesClass.ts | ||
| models/AllOfWithSingleRef.ts | ||
| models/Animal.ts | ||
| models/ApiResponse.ts | ||
| models/ArrayOfArrayOfNumberOnly.ts | ||
| models/ArrayOfNumberOnly.ts | ||
| models/ArrayTest.ts | ||
| models/Capitalization.ts | ||
| models/Cat.ts | ||
| models/Category.ts | ||
| models/ClassModel.ts | ||
| models/Client.ts | ||
| models/DeprecatedObject.ts | ||
| models/Dog.ts | ||
| models/EnumArrays.ts | ||
| models/EnumClass.ts | ||
| models/EnumTest.ts | ||
| models/FakeBigDecimalMap200Response.ts | ||
| models/FileSchemaTestClass.ts | ||
| models/Foo.ts | ||
| models/FooGetDefaultResponse.ts | ||
| models/FormatTest.ts | ||
| models/HasOnlyReadOnly.ts | ||
| models/HealthCheckResult.ts | ||
| models/List.ts | ||
| models/MapTest.ts | ||
| models/MixedPropertiesAndAdditionalPropertiesClass.ts | ||
| models/Model200Response.ts | ||
| models/ModelFile.ts | ||
| models/Name.ts | ||
| models/NullableClass.ts | ||
| models/NumberOnly.ts | ||
| models/ObjectSerializer.ts | ||
| models/ObjectWithDeprecatedFields.ts | ||
| models/Order.ts | ||
| models/OuterComposite.ts | ||
| models/OuterEnum.ts | ||
| models/OuterEnumDefaultValue.ts | ||
| models/OuterEnumInteger.ts | ||
| models/OuterEnumIntegerDefaultValue.ts | ||
| models/OuterObjectWithEnumProperty.ts | ||
| models/Pet.ts | ||
| models/ReadOnlyFirst.ts | ||
| models/Return.ts | ||
| models/SingleRefType.ts | ||
| models/SpecialModelName.ts | ||
| models/Tag.ts | ||
| models/User.ts | ||
| models/all.ts | ||
| package.json | ||
| rxjsStub.ts | ||
| servers.ts | ||
| tsconfig.json | ||
| types/ObjectParamAPI.ts | ||
| types/ObservableAPI.ts | ||
| types/PromiseAPI.ts | ||
| util.ts |
1 change: 1 addition & 0 deletions
1
samples/openapi3/client/petstore/typescript/builds/explode-query/.openapi-generator/VERSION
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 7.9.0-SNAPSHOT |
66 changes: 66 additions & 0 deletions
66
samples/openapi3/client/petstore/typescript/builds/explode-query/AnotherFakeApi.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| # petstore.AnotherFakeApi | ||
|
|
||
| All URIs are relative to *http://petstore.swagger.io:80/v2* | ||
|
|
||
| Method | HTTP request | Description | ||
| ------------- | ------------- | ------------- | ||
| [**_123testSpecialTags**](AnotherFakeApi.md#_123testSpecialTags) | **PATCH** /another-fake/dummy | To test special tags | ||
|
|
||
|
|
||
| # **_123testSpecialTags** | ||
| > Client _123testSpecialTags(client) | ||
|
|
||
| To test special tags and operation ID starting with number | ||
|
|
||
| ### Example | ||
|
|
||
|
|
||
| ```typescript | ||
| import { petstore } from 'ts-petstore-client'; | ||
| import * as fs from 'fs'; | ||
|
|
||
| const configuration = petstore.createConfiguration(); | ||
| const apiInstance = new petstore.AnotherFakeApi(configuration); | ||
|
|
||
| let body:petstore.AnotherFakeApi123testSpecialTagsRequest = { | ||
| // Client | client model | ||
| client: { | ||
| client: "client_example", | ||
| }, | ||
| }; | ||
|
|
||
| apiInstance._123testSpecialTags(body).then((data:any) => { | ||
| console.log('API called successfully. Returned data: ' + data); | ||
| }).catch((error:any) => console.error(error)); | ||
| ``` | ||
|
|
||
|
|
||
| ### Parameters | ||
|
|
||
| Name | Type | Description | Notes | ||
| ------------- | ------------- | ------------- | ------------- | ||
| **client** | **Client**| client model | | ||
|
|
||
|
|
||
| ### Return type | ||
|
|
||
| **Client** | ||
|
|
||
| ### Authorization | ||
|
|
||
| No authorization required | ||
|
|
||
| ### HTTP request headers | ||
|
|
||
| - **Content-Type**: application/json | ||
| - **Accept**: application/json | ||
|
|
||
|
|
||
| ### HTTP response details | ||
| | Status code | Description | Response headers | | ||
| |-------------|-------------|------------------| | ||
| **200** | successful operation | - | | ||
|
|
||
| [[Back to top]](#) [[Back to API list]](README.md#documentation-for-api-endpoints) [[Back to Model list]](README.md#documentation-for-models) [[Back to README]](README.md) | ||
|
|
||
|
|
57 changes: 57 additions & 0 deletions
57
samples/openapi3/client/petstore/typescript/builds/explode-query/DefaultApi.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # petstore.DefaultApi | ||
|
|
||
| All URIs are relative to *http://petstore.swagger.io:80/v2* | ||
|
|
||
| Method | HTTP request | Description | ||
| ------------- | ------------- | ------------- | ||
| [**fooGet**](DefaultApi.md#fooGet) | **GET** /foo | | ||
|
|
||
|
|
||
| # **fooGet** | ||
| > fooGet() | ||
|
|
||
|
|
||
| ### Example | ||
|
|
||
|
|
||
| ```typescript | ||
| import { petstore } from 'ts-petstore-client'; | ||
| import * as fs from 'fs'; | ||
|
|
||
| const configuration = petstore.createConfiguration(); | ||
| const apiInstance = new petstore.DefaultApi(configuration); | ||
|
|
||
| let body:any = {}; | ||
|
|
||
| apiInstance.fooGet(body).then((data:any) => { | ||
| console.log('API called successfully. Returned data: ' + data); | ||
| }).catch((error:any) => console.error(error)); | ||
| ``` | ||
|
|
||
|
|
||
| ### Parameters | ||
| This endpoint does not need any parameter. | ||
|
|
||
|
|
||
| ### Return type | ||
|
|
||
| void (empty response body) | ||
|
|
||
| ### Authorization | ||
|
|
||
| No authorization required | ||
|
|
||
| ### HTTP request headers | ||
|
|
||
| - **Content-Type**: Not defined | ||
| - **Accept**: application/json | ||
|
|
||
|
|
||
| ### HTTP response details | ||
| | Status code | Description | Response headers | | ||
| |-------------|-------------|------------------| | ||
| **0** | response | - | | ||
|
|
||
| [[Back to top]](#) [[Back to API list]](README.md#documentation-for-api-endpoints) [[Back to Model list]](README.md#documentation-for-models) [[Back to README]](README.md) | ||
|
|
||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.