Tk render 3D#13113
Conversation
algorithms-keeper
Bot
added
awaiting reviews
algorithms-keeper
Bot
added
the
require tests
![algorithms-keeper[bot]](https://avatars.gh.lumenfield.work/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| cube.position = Vector3D(-0.5, -0.5, 3) | ||
| self.meshes.append(cube) | ||
|
|
||
| def on_key(self, event: tk.Event) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphics/interactive_3d_renderer.py, please provide doctest for the function on_key
| elif event.keysym == "Right": | ||
| self.camera.rotate(dyaw=angle_step) | ||
|
|
||
| def on_resize(self, event: tk.Event) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphics/interactive_3d_renderer.py, please provide doctest for the function on_resize
| self.height = event.height | ||
| self.canvas.config(width=self.width, height=self.height) | ||
|
|
||
| def update(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphics/interactive_3d_renderer.py, please provide doctest for the function update
| for mesh in self.meshes: | ||
| mesh.rotation.y_coordinate += 2 | ||
|
|
||
| def mainloop(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphics/interactive_3d_renderer.py, please provide doctest for the function mainloop
| def mainloop(self) -> None: | ||
| """Start the animation and rendering loop.""" | ||
|
|
||
| def loop() -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphics/interactive_3d_renderer.py, please provide doctest for the function loop
| loop() | ||
| self.root.mainloop() | ||
|
|
||
| def close(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphics/interactive_3d_renderer.py, please provide doctest for the function close
| self.running = False | ||
| self.root.destroy() | ||
|
|
||
| def render(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphics/interactive_3d_renderer.py, please provide doctest for the function render
algorithms-keeper
Bot
added
tests are failing
1 participant
Describe your change:
Checklist: