Skip to content

fix(pnpm): add packages to pnpm-workspace.yaml to include root package#113

Open
marcalexiei wants to merge 5 commits into
changesets:masterfrom
marcalexiei:fix-deploy-pnpm
Open

fix(pnpm): add packages to pnpm-workspace.yaml to include root package#113
marcalexiei wants to merge 5 commits into
changesets:masterfrom
marcalexiei:fix-deploy-pnpm

Conversation

@marcalexiei
Copy link
Copy Markdown
Contributor

@marcalexiei marcalexiei commented May 11, 2026

Running build in Washington, D.C., USA (East) – iad1
Build machine configuration: 4 cores, 8 GB
Cloning github.com/changesets/bot (Branch: master, Commit: ea5e300)
Cloning completed: 259.000ms
Skipping build cache since Package Manager changed from "yarn" to "pnpm"
Running "vercel build"
Detected `pnpm-lock.yaml` 9 which may be generated by pnpm@9.x or pnpm@10.x
Using pnpm@9.x based on project creation date
To use pnpm@10.x, manually opt in using corepack (https://vercel.com/docs/deployments/configure-a-build#corepack)
Installing dependencies...
 ERROR  packages field missing or empty
For help, run: pnpm help install
Error: Command "pnpm install" exited with 1

  • I updated the packageManager field, removing the hash to keep the same format that was previously used with yarn.
    "packageManager": "yarn@1.22.22"

    Not needed, adding repo root to pnpm-workspace.yaml#packages solved the issue
  • Since the error mentions packages field missing or empty, I added a packages entry pointing to the repository root in pnpm-workspace.yaml.

Additional changes to try if the deployment still fails

  • Clear any existing build cache that may still contain Yarn artifacts and interfere with the new pnpm-based build.
  • The Vercel documentation also mentions enabling Corepack explicitly by setting: ENABLE_EXPERIMENTAL_COREPACK=1
    Reference: https://vercel.com/docs/builds/configure-a-build#corepack

@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

@marcalexiei is attempting to deploy a commit to the Changesets Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
changesets-bot Ready Ready Preview, Comment May 11, 2026 6:41pm

Request Review

@Andarist
Copy link
Copy Markdown
Member

Hm, the preview deployment got built but something looks off cause I see this in the logs:

index.ts(101,53): error TS7006: Parameter 'commentsResponse' implicitly has an 'any' type.
index.ts(104,8): error TS7006: Parameter 'comment' implicitly has an 'any' type.
index.ts(114,29): error TS7006: Parameter 'filesResponse' implicitly has an 'any' type.
index.ts(116,8): error TS7006: Parameter 'file' implicitly has an 'any' type.
index.ts(161,51): error TS7006: Parameter 'filesResponse' implicitly has an 'any' type.
index.ts(162,39): error TS7031: Binding element 'filename' implicitly has an 'any' type.
index.ts(172,171): error TS2339: Property 'message' does not exist on type 'ValidationError'.
get-changed-packages.ts(67,16): error TS2339: Property 'json' does not exist on type 'Response'.
get-changed-packages.ts(78,16): error TS2339: Property 'text' does not exist on type 'Response'.

I'm not sure if this is a new issue or if that was present with Yarn

Comment thread tsconfig.json
"rewriteRelativeImportExtensions": true,
"skipLibCheck": true,
"lib": ["esnext"],
"types": ["node"],
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get-changed-packages.ts(67,16): error TS2339: Property 'json' does not exist on type 'Response'.
get-changed-packages.ts(78,16): error TS2339: Property 'text' does not exist on type 'Response'.

Those lines make me think there’s a mismatch in the loaded types.
Hopefully, explicitly adding them to the tsconfig will solve the issue.

The errors in index seem to come from probot’s types, which also rely on @types/node, so hopefully those are fixed as well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants