fix(pnpm): add packages to pnpm-workspace.yaml to include root package#113
Open
marcalexiei wants to merge 5 commits into
Open
fix(pnpm): add packages to pnpm-workspace.yaml to include root package#113marcalexiei wants to merge 5 commits into
marcalexiei wants to merge 5 commits into
Conversation
|
@marcalexiei is attempting to deploy a commit to the Changesets Team on Vercel. A member of the Team first needs to authorize it. |
da4fef2 to
ffc5b8f
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ec44c8b to
9e109a8
Compare
Member
|
Hm, the preview deployment got built but something looks off cause I see this in the logs: I'm not sure if this is a new issue or if that was present with Yarn |
marcalexiei
commented
May 11, 2026
| "rewriteRelativeImportExtensions": true, | ||
| "skipLibCheck": true, | ||
| "lib": ["esnext"], | ||
| "types": ["node"], |
Contributor
Author
There was a problem hiding this comment.
get-changed-packages.ts(67,16): error TS2339: Property 'json' does not exist on type 'Response'.
get-changed-packages.ts(78,16): error TS2339: Property 'text' does not exist on type 'Response'.
Those lines make me think there’s a mismatch in the loaded types.
Hopefully, explicitly adding them to the tsconfig will solve the issue.
The errors in index seem to come from probot’s types, which also rely on @types/node, so hopefully those are fixed as well now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm#112 (comment)I updated the
"packageManager": "yarn@1.22.22"
packageManagerfield, removing the hash to keep the same format that was previously used withyarn.bot/package.json
Line 49 in af23c7e
Not needed, adding repo root to
pnpm-workspace.yaml#packagessolved the issuepackages field missing or empty, I added apackagesentry pointing to the repository root inpnpm-workspace.yaml.Additional changes to try if the deployment still fails
ENABLE_EXPERIMENTAL_COREPACK=1Reference: https://vercel.com/docs/builds/configure-a-build#corepack