Skip to content

fix(pnpm): add packages to pnpm-workspace.yaml to include root package #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcalexiei wants to merge 5 commits into
base: master
Choose a base branch
from
+9 −0
Open

fix(pnpm): add packages to pnpm-workspace.yaml to include root package #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffc5b8f
fix(pnpm): add packages to pnpm-workspace.yaml to include root package
marcalexiei May 11, 2026
9e109a8
add comment explaining root package entry in pnpm workspace
marcalexiei May 11, 2026
8506f13
restore sha in `packageManager` field
marcalexiei May 11, 2026
5ab7657
add explcit node types to tsconfig
marcalexiei May 11, 2026
1c732bc
remove double ` from explanation comment
marcalexiei May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
packages:
# Why mark the repository root as a package?
#
# It appears that Vercel fails during the `pnpm install` step
# when the packages field is missing from pnpm-workspace.yaml.
# @see https://github.com/changesets/bot/pull/113
- "."

allowBuilds:
msw: true

Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"rewriteRelativeImportExtensions": true,
"skipLibCheck": true,
"lib": ["esnext"],
"types": ["node"],
Copy link
Copy Markdown
Contributor Author

@marcalexiei marcalexiei May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

get-changed-packages.ts(67,16): error TS2339: Property 'json' does not exist on type 'Response'.
get-changed-packages.ts(78,16): error TS2339: Property 'text' does not exist on type 'Response'.

Those lines make me think there’s a mismatch in the loaded types.
Hopefully, explicitly adding them to the tsconfig will solve the issue.

The errors in index seem to come from probot’s types, which also rely on @types/node, so hopefully those are fixed as well now.

"allowJs": false,
"incremental": false,
"resolveJsonModule": true,
Expand Down