feat: Remove final modifier from *Message methods in DefaultLanguageClient

[FlorianKroiss]

This makes it easier for developers using LSP4E to create a language client with custom behavior.

Resolves #1367

[rubenporras]

Could it be that for your use case it could be better to allow customization of the ServerMessageHandler? Can you please provide more info about why this is necessary to change the logging behaviour in your case?

[FlorianKroiss]

Can you please provide more info about why this is necessary to change the logging behaviour in your case?

Our application has a Log View which displays log messages coming from all over the application, to make it easier for users to diagnose problems. This includes log messages coming the LSP4E Plugin.

We are using a language server which is quite verbose during startup and publishes a lot of INFO messages which are handled by DefaultLanguageClient.logMessage(). I would like to lower their log-level to DEBUG to reduce the log noise before handing the messages to the logger, but I can't intercept the message because logMessage is final.

Could it be that for your use case it could be better to allow customization of the ServerMessageHandler?

Making the logging behavior in ServerMessageHandler configurable would probably work, but a developer might only want to change the log level if the message comes from a specific LS or has certain content.

Given that every custom LanguageClient must be a subclass of DefaultLanguageClient, I thought that it's reasonable to make all of it's functionality overridable. For example, a developer might also want to change how showMessage is handled.

[rubenporras]

Could we just remove the final from the *Message methods only?

[FlorianKroiss]

That's fine for me.