Skip to content

feat: Remove final modifier from *Message methods in DefaultLanguageClient #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenporras merged 1 commit into from
Nov 7, 2025
Merged

feat: Remove final modifier from *Message methods in DefaultLanguageClient #1370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions org.eclipse.lsp4e/src/org/eclipse/lsp4e/client/DefaultLanguageClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,12 @@ public void telemetryEvent(@Nullable Object object) {
}

@Override
public final CompletableFuture<MessageActionItem> showMessageRequest(ShowMessageRequestParams requestParams) {
public CompletableFuture<MessageActionItem> showMessageRequest(ShowMessageRequestParams requestParams) {
return ServerMessageHandler.showMessageRequest(wrapper, requestParams);
}

@Override
public final void showMessage(MessageParams messageParams) {
public void showMessage(MessageParams messageParams) {
ServerMessageHandler.showMessage(wrapper.serverDefinition.label, messageParams);
}

Expand All @@ -111,7 +111,7 @@ public final void publishDiagnostics(PublishDiagnosticsParams diagnostics) {
}

@Override
public final void logMessage(MessageParams message) {
public void logMessage(MessageParams message) {
CompletableFuture.runAsync(() -> ServerMessageHandler.logMessage(wrapper, message));
}

Expand Down
Loading