Give FormHeading a distinct background in the light theme#3950
Draft
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Draft
Give FormHeading a distinct background in the light theme#3950vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
The as-shipped light theme set both Form and FormHeading to #ffffff plus a matching text-background-color, so the form heading area was visually indistinguishable from the form body. Split the joint Form/FormHeading rule, set FormHeading and the Form's text-background-color to #eaeaea (matching the Section title bar) so the heading stands out against the white body.
Member
|
Just one question that just now comes to my mind: |
Contributor
Author
All I can say that Version: 2026-03 (4.39) does NOT have the gray background. Why? I don't know and don't have the interest to research that. |
Member
Let me have a look if I can find out something... |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The light theme set both
FormandFormHeadingto#ffffffplus a matchingtext-background-color, so the form heading area (the bar containing the editor title and toolbar icons) was visually indistinguishable from the form body and the icons looked free-floating.Split the joint
Form, FormHeadingrule ine4-light_globalstyle.cssand giveFormHeading(and the Form'stext-background-color)#eaeaea— the same color the Section title bars already use — so the heading reads as a distinct band against the white body.